Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build&publish the base container to GHCR + point to it from action #58

Closed
webknjaz opened this issue Mar 25, 2021 · 6 comments · Fixed by #230
Closed

Build&publish the base container to GHCR + point to it from action #58

webknjaz opened this issue Mar 25, 2021 · 6 comments · Fixed by #230
Assignees
Labels
enhancement New feature or request

Comments

@webknjaz
Copy link
Member

Example image build+publish workflow: https://github.com/ansible/pylibssh/blob/devel/.github/workflows/build-manylinux-container-images.yml

Example of an action pointer: https://github.com/fedora-python/tox-github-action/blob/9f7d1ff/action.yaml#L14

@webknjaz webknjaz added the enhancement New feature or request label Mar 25, 2021
@webknjaz webknjaz self-assigned this Mar 25, 2021
@richard-engineering
Copy link

More needed now that 2FA is being enforced as the build times are quite long.

@webknjaz
Copy link
Member Author

What does it have to do with 2FA?

@richard-engineering
Copy link

richard-engineering commented Oct 16, 2023

This Github Action is officially recommended by the official PyPI docs linked to by the article on 2FA enforcement. Previously prior to 2FA enforcement uploading could be done via username/password (eg via flit publish) in CI which is a rather quick process. It's unfortunate that the recommended reference solution linked in the documentation can take up to 5+ minutes to build. Putting this on GHCR would avoid the need to build the images.

@webknjaz
Copy link
Member Author

Using API tokens still works, it hasn't gone anywhere. Putting shared username+password pairs online was always problematic, and everyone should've switched to scoped API tokens like 5 years ago.

@shenxianpeng
Copy link
Contributor

shenxianpeng commented Apr 21, 2024

To speed up user workflows, another option is using composite action, it is faster than building Dockerfile, probably the same as pulling a prepared docker image from GHCR.

Composite action will drop using docker to make GitHub action simpler, and it would support non-Linux OS.

I can draft a PR kindly for your review If you would like to have a look.

@webknjaz
Copy link
Member Author

No, there are legit reasons for not doing that. I don't want to encourage antipatterns, for example. And the level of control/side effects is unacceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants