Bump actions/download-artifact from 3 to 4 (#1186)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ofek Lev <[email protected]>
pypa · Mar 4, 2024 · 03b1bca · 03b1bca
1 parent e2ae3f6
commit 03b1bca
Show file tree

Hide file tree

Showing 5 changed files with 43 additions and 36 deletions.
diff --git a/.github/workflows/build-hatch.yml b/.github/workflows/build-hatch.yml
@@ -41,7 +41,7 @@ jobs:
       run: python -m build
 
     - name: Upload artifacts
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: python-artifacts
         path: dist/*
@@ -139,7 +139,7 @@ jobs:
 
     - name: Download Python artifacts
       if: ${{ !startsWith(github.event.ref, 'refs/tags') }}
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: python-artifacts
         path: dist
@@ -189,17 +189,17 @@ jobs:
 
     - name: Upload staged archive
       if: runner.os != 'Linux'
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
-        name: staged-${{ runner.os }}
+        name: staged-${{ runner.os }}-${{ matrix.job.target }}
         path: packaging/*
         if-no-files-found: error
 
     - name: Upload archive
       if: runner.os == 'Linux'
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
-        name: standalone
+        name: standalone-${{ matrix.job.target }}
         path: packaging/*
         if-no-files-found: error
 
@@ -225,10 +225,11 @@ jobs:
       run: pip install pyoxidizer==${{ env.PYOXIDIZER_VERSION }}
 
     - name: Download staged binaries
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
-        name: staged-${{ runner.os }}
+        pattern: staged-${{ runner.os }}-*
         path: archives
+        merge-multiple: true
 
     - name: Extract staged binaries
       run: |-
@@ -261,17 +262,18 @@ jobs:
         mv build/*/release/*/*.{exe,msi} installers
 
     - name: Upload binaries
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
-        name: standalone
+        name: standalone-${{ runner.os }}
         path: archives/*
         if-no-files-found: error
 
     - name: Upload installers
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
-        name: installers
+        name: installers-${{ runner.os }}
         path: installers/*
+        if-no-files-found: error
 
   macos-packaging:
     name: Build macOS installer and sign/notarize artifacts
@@ -304,10 +306,11 @@ jobs:
         tar --strip-components=1 -xzf - -C /usr/local/bin "$ARCHIVE_NAME/rcodesign"
 
     - name: Download staged binaries
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
-        name: staged-${{ runner.os }}
+        pattern: staged-${{ runner.os }}-*
         path: archives
+        merge-multiple: true
 
     - name: Extract staged binaries
       run: |-
@@ -422,17 +425,18 @@ jobs:
         "signed/${{ steps.pkg.outputs.path }}"
 
     - name: Upload binaries
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
-        name: standalone
+        name: standalone-${{ runner.os }}
         path: archives/*
         if-no-files-found: error
 
     - name: Upload installer
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
-        name: installers
+        name: installers-${{ runner.os }}
         path: signed/${{ steps.pkg.outputs.path }}
+        if-no-files-found: error
 
   publish:
     name: Publish release
@@ -450,22 +454,24 @@ jobs:
 
     steps:
     - name: Download Python artifacts
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: python-artifacts
         path: dist
 
     - name: Download binaries
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
-        name: standalone
+        pattern: standalone-*
         path: archives
+        merge-multiple: true
 
     - name: Download installers
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
-        name: installers
+        pattern: installers-*
         path: installers
+        merge-multiple: true
 
     - name: Add assets to current release
       uses: softprops/action-gh-release@v1

diff --git a/.github/workflows/build-hatchling.yml b/.github/workflows/build-hatchling.yml
@@ -19,10 +19,10 @@ jobs:
     - name: Build source distribution
       run: python -m build backend
 
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: artifacts
-        path: backend/dist/*
+        path: backend/dist
         if-no-files-found: error
 
   publish:
@@ -35,7 +35,7 @@ jobs:
       id-token: write
 
     steps:
-    - uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v4
       with:
         name: artifacts
         path: dist

diff --git a/.github/workflows/docs-dev.yml b/.github/workflows/docs-dev.yml
@@ -60,7 +60,7 @@ jobs:
     - name: Create archive
       run: git archive -o site.zip gh-pages
 
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: documentation
         path: site.zip
@@ -73,7 +73,7 @@ jobs:
     - build
 
     steps:
-    - uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v4
       with:
         name: documentation
 

diff --git a/.github/workflows/docs-release.yml b/.github/workflows/docs-release.yml
@@ -65,7 +65,7 @@ jobs:
     - name: Create archive
       run: git archive -o site.zip gh-pages
 
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: documentation
         path: site.zip
@@ -76,7 +76,7 @@ jobs:
     - build
 
     steps:
-    - uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v4
       with:
         name: documentation
 

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -56,10 +56,10 @@ jobs:
       run: mv .coverage ".coverage.${{ matrix.os }}.${{ matrix.python-version }}"
 
     - name: Upload coverage data
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
-        name: coverage-data
-        path: .coverage.*
+        name: coverage-${{ matrix.os }}-${{ matrix.python-version }}
+        path: .coverage*
 
   coverage:
     name: Report coverage
@@ -82,9 +82,10 @@ jobs:
       run: hatch build --hooks-only
 
     - name: Download coverage data
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
-        name: coverage-data
+        pattern: coverage-*
+        merge-multiple: true
 
     - name: Combine coverage data
       run: hatch run coverage:combine
@@ -95,7 +96,7 @@ jobs:
         hatch run coverage:report-uncovered-html
 
     - name: Upload uncovered HTML report
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: uncovered-html-report
         path: htmlcov