Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax version check for dev version? #515

Closed
blink1073 opened this issue Sep 25, 2022 · 3 comments · Fixed by #537
Closed

Relax version check for dev version? #515

blink1073 opened this issue Sep 25, 2022 · 3 comments · Fixed by #537

Comments

@blink1073
Copy link
Contributor

Might it be possible to not raise a value error when the current version is a dev version (.is_devrelease)?

/opt/pipx/.cache/d35b7fb1f39ba97/lib/python3.10/site-packages/hatchling/vers │
│ ion/scheme/standard.py:48 in update                                          │
│                                                                              │
│   45 │   │   │   │                                                           │
│   46 │   │   │   │   next_version = Version(version)                         │
│   47 │   │   │   │   if next_version <= original:                            │
│ ❱ 48 │   │   │   │   │   raise ValueError(                                   │
│   49 │   │   │   │   │   │   f'Version `{version}` is not higher than the or │
│   50 │   │   │   │   │   )                                                   │
│   51 │   │   │   │   else:                                                   │
╰─────────────────────────────────────────���────────────────────────────────────╯
ValueError: Version `0.24.4` is not higher than the original version
`1.0.0.dev0`
@OldGrumpyViking
Copy link
Contributor

OldGrumpyViking commented Sep 26, 2022

I do not think this is a good idea.
Can you elaborate on what your use-case is?

@blink1073
Copy link
Contributor Author

A common pattern we use in Jupyter is to bump to a .dev0 minor version bump after making a release. If we have a bug fix that needs to go out in the interim, we'd rather not be forced to create a branch every time.

@ofek
Copy link
Collaborator

ofek commented Sep 26, 2022

I do not think this is a good idea.

Agreed, but we can add an option to disable the check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants