Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manylinux support logic ignores overrides #263

Closed
aragilar opened this issue Jan 26, 2020 · 2 comments
Closed

Manylinux support logic ignores overrides #263

aragilar opened this issue Jan 26, 2020 · 2 comments

Comments

@aragilar
Copy link

aragilar commented Jan 26, 2020

With the switch to use packaging.tags in pip 20, the values in _manylinux.py may be overridden by

# Support for a later manylinux implies support for an earlier version.
, which assumes that if a newer manylinux is supported, older ones must be too, and overrides the value (pip lacked this additional logic, hence why there were no previous issues). While this logic could be removed, a better solution would seem to be to have an explicit override (as contained in #262). This would seem to me to solve pypa/pip#3689.

There's an associated pip issue (pypa/pip#7648), which I created to track when this issue is fixed in pip.

@chrahunt
Copy link
Member

chrahunt commented Jan 26, 2020

As mentioned in #262, implementing manylinux_compatible as described in PEP 600 should do what we want. Note from the discussion page that this might not be straightforward.

@brettcannon
Copy link
Member

#280 implemented PEP 600, so I believe this issue is taken care of. If I'm misunderstanding what is being asked then please let me know and we can reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants