Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand our PyPI caching to the dependency collection stage #187

Closed
woodruffw opened this issue Dec 6, 2021 · 1 comment · Fixed by #194
Closed

Expand our PyPI caching to the dependency collection stage #187

woodruffw opened this issue Dec 6, 2021 · 1 comment · Fixed by #194
Assignees
@woodruffw
Labels
component:dep-sources Dependency sources enhancement New feature or request performance Something isn't as fast or responsive as it should be.

Comments

@woodruffw
Copy link
Member

Looking at our code, I think we're only performing HTTP caching during the audit stage -- we cache each JSON response from PyPI.

We should also use the cache during the dependency collection stage, since we repeatedly hit the simple index and download source distributions.
@woodruffw woodruffw added enhancement New feature or request component:dep-sources Dependency sources performance Something isn't as fast or responsive as it should be. labels Dec 6, 2021
@woodruffw woodruffw mentioned this issue Dec 6, 2021
Merged
@woodruffw
Copy link
Member Author

#188 will get us much closer to this by creating a generic caching API for all of our components.

@woodruffw woodruffw self-assigned this Dec 6, 2021
@woodruffw woodruffw mentioned this issue Dec 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodruffw woodruffw

Labels
component:dep-sources Dependency sources enhancement New feature or request performance Something isn't as fast or responsive as it should be.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pip_audit, test: perform even more PyPI caching pypa/pip-audit
1 participant
@woodruffw