Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review how pip-audit handles multiple vulnerabilities with the same alias #231

Closed
di opened this issue Feb 3, 2022 · 4 comments · Fixed by #232
Closed

Review how pip-audit handles multiple vulnerabilities with the same alias #231

di opened this issue Feb 3, 2022 · 4 comments · Fixed by #232
Labels
component:vuln-sources Components that provide sources of vulnerability information pri:high High(er) priority tasks

Comments

@di
Copy link
Member

di commented Feb 3, 2022

We should review how pip-audit handles multiple vulnerabilities with the same alias. In the future, it may be necessary to de-duplicate two or more vulnerabilities with different IDs, but the same alias.

(cc @oliverchang)

@woodruffw woodruffw added the component:vuln-sources Components that provide sources of vulnerability information label Feb 4, 2022
@woodruffw
Copy link
Member

Making sure I understand: each vulnerability has multiple potential aliases, e.g. multiple CVEs or other identifiers. With this behavior change, would we be checking whether two vulnerabilities have the exact same alias set, or have at least one alias in common?

@di
Copy link
Member Author

di commented Feb 4, 2022

I believe the case we're interested in is when two vulnerability reports affect the same dependency and have a shared alias, but I'll let @oliverchang confirm.

@oliverchang
Copy link

Yep! We'd want to group any vulnerabilities that have any aliases (including the id) common.

E.g. given

{"id": "PYSEC-2022-19", "aliases": ["CVE-2022-22818"]}
{"id": "GHSA-95rw-fx8r-36v6", "aliases": ["CVE-2022-22818"]}
{"id": "SOME-OTHER-ID", "aliases": ["GHSA-95rw-fx8r-36v6"]}

We'd want to group them all of these together.

@woodruffw
Copy link
Member

(including the id)

That's an important detail! I'll make sure the changes in #232 include that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vuln-sources Components that provide sources of vulnerability information pri:high High(er) priority tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants