Sort Requires and Required-By fields for pip show
#10422
Conversation
src/pip/_internal/commands/show.py
Outdated
| requires = sorted( | ||
| (req.name for req in dist.iter_dependencies()), key=lambda pkg: pkg.lower() | ||
| ) | ||
| required_by = sorted(_get_requiring_packages(dist), key=lambda pkg: pkg.lower()) |
There was a problem hiding this comment.
Use operator.methodcaller("lower") instead.
Also, since _get_requiring_packages not longer needs return a list, please change it to return an iterator instead.
There was a problem hiding this comment.
We could even use key=str.lower here.
There was a problem hiding this comment.
@uranusjr, good point. I have converted it to an iterator.
@pradyunsg, I didn't think of that. It's definitely nicer than a lambda. I have changed it.
On a side note, I don't really know what the development process is here. Should I squash and rebase once this is approved and before being merged, or is that not something I need to worry about?
|
@uranusjr, makes sense. I've deleted the old news file and created a feature one with similar wording. |
|
Thanks @aphedges! ^>^ |
I have noticed that when running
pip show,Requireshas a non-deterministic order across runs andRequired-Byhas deterministic order but without any clear logic behind the order. I propose that we change this to improve readability. This was first a problem for me when it made comparing the results ofpip showacross environments more difficult than a simple diff.Of the three other
Listfields, one (Files) is already being sorted, so this change does not seem out-of-place. The remaining other fields (ClassfiersandEntry-points) are not sorted inpip show, but they might be sorted elsewhere or are intentionally left unsorted, so I did not touch them.I sort the packages case-insensitively to match the logic in
pip listandpip freeze.This seems like a
trivialchange to me, but if you think this requires further discussion, I can make an issue for it.