Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata preparation log was wrong indent #10524

Closed
1 task done
sbidoul opened this issue Sep 29, 2021 · 1 comment · Fixed by #10525
Closed
1 task done

Metadata preparation log was wrong indent #10524

sbidoul opened this issue Sep 29, 2021 · 1 comment · Fixed by #10525
Labels
type: bug A confirmed bug or unintended behavior
Milestone

Comments

@sbidoul
Copy link
Member

sbidoul commented Sep 29, 2021

Description

With pyproject.toml:

pip install -e ./pkga
Obtaining file:///home/me/tmp/pkga
  Installing build dependencies ... done
  Getting requirements to build editable ... done
    Preparing editable metadata (pyproject.toml) ... done
    Build backend does not support editables, falling back to setup.py egg_info.
    Preparing metadata (setup.py) ... done
...

Without pyproject.toml:

pip install -e ./pkga
Obtaining file:///home/me/tmp/pkga
    Preparing metadata (setup.py) ... done

Notice the indent of the metadata preparation steps. With pyproject.toml, they appear to be "inside" Getting requirements to build editable, which is not correct as metadata preparation is done after that step. Without pyproject.toml, the indent is 4 characters instead of two.

Expected behavior

Dedent metadata preparation log entries.

pip version

21.3dev, 21.2 as well

Python version

irrelevant

OS

Linux, probably irrelevant

How to Reproduce

pip install -e of any project.

Output

No response

Code of Conduct

@sbidoul sbidoul added type: bug A confirmed bug or unintended behavior S: needs triage Issues/PRs that need to be triaged labels Sep 29, 2021
@sbidoul sbidoul added this to the 21.3 milestone Sep 29, 2021
@sbidoul
Copy link
Member Author

sbidoul commented Sep 29, 2021

Note this also applies to non-editable installs with pyproject.toml.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2021
@pradyunsg pradyunsg removed the S: needs triage Issues/PRs that need to be triaged label Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug A confirmed bug or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants