Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing news fragments related to rich adoption #10705

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Add missing news fragments related to rich adoption #10705

merged 1 commit into from
Dec 3, 2021

Conversation

pradyunsg
Copy link
Member

No description provided.

DiddiLeija
DiddiLeija reviewed Dec 3, 2021
View reviewed changes
Copy link
Member

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's fine, but I would like to point 2 things (see below).

news/10462.feature.rst Outdated Show resolved Hide resolved
news/10462.removal.rst Outdated Show resolved Hide resolved
@pradyunsg
Copy link
Member Author

Yes, and the CI caught it as well! :)

DiddiLeija
DiddiLeija approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done now from my side!

@uranusjr
Copy link
Member

uranusjr commented Dec 3, 2021

Someone should add a pre-commit hook to check for backticks :p

Does rst-backticks work? https://github.com/pre-commit/pygrep-hooks

@uranusjr uranusjr merged commit 2e3fab3 into pypa:main Dec 3, 2021
@pradyunsg pradyunsg deleted the add-missing-news branch December 3, 2021 20:14
@pradyunsg
Copy link
Member Author

Someone should add a pre-commit hook to check for backticks :p

Done! c5744d5 :P

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DiddiLeija DiddiLeija DiddiLeija approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pradyunsg @uranusjr @DiddiLeija