Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the role of the egg URL fragment #11676

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Dec 28, 2022

Clarify that the egg fragment is only necessary for editable VCS installs, and otherwise not necessary anymore.

@sbidoul sbidoul force-pushed the clarify-egg-fragment-docs-sbi branch from cc04a99 to e367c00 Compare December 28, 2022 11:16
@sbidoul sbidoul added this to the 23.0 milestone Dec 28, 2022
@pradyunsg
Copy link
Member

Should we try to allow -e pep508@git+... and completely eliminate #egg URLs?

@sbidoul sbidoul force-pushed the clarify-egg-fragment-docs-sbi branch from 6144f05 to e25df3d Compare December 28, 2022 14:21
@sbidoul
Copy link
Member Author

sbidoul commented Dec 28, 2022

Should we try to allow -e pep508@git+... and completely eliminate #egg URLs?

We should, yes. @uranusjr investigated that in #9471.

@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Dec 28, 2022
@sbidoul sbidoul force-pushed the clarify-egg-fragment-docs-sbi branch from e25df3d to 668ea3f Compare December 28, 2022 22:25
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Dec 28, 2022
@sbidoul
Copy link
Member Author

sbidoul commented Dec 28, 2022

Rebased

@uranusjr
Copy link
Member

Using PEP 508 syntax for editable is still blocked by pypa/packaging#264 for the moment.

@uranusjr uranusjr merged commit fb02491 into pypa:main Dec 29, 2022
@sbidoul sbidoul deleted the clarify-egg-fragment-docs-sbi branch December 29, 2022 09:57
@sbidoul
Copy link
Member Author

sbidoul commented Dec 29, 2022

Using PEP 508 syntax for editable is still blocked by pypa/packaging#264 for the moment.

Partly, but I think that one only blocks git+file:// URLs ?

IIRC, the slightly complicated part is allowing name[extras] @ absolute_or_relative_local_path which is not PEP 508 syntax because absolute_or_relative_local_path is not an URI.

updated: hm, no we can do pip install -e "absolute_or_relative_local_path[extras]" today without involving the project name, so pip install -e "name @ uri" might be all we need.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants