Include AUTHORS.txt in pip's wheels
#11882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wheels already include `LICENSE.txt`, which refers to `AUTHORS.txt`, so `AUTHORS.txt` should be included too. Conveniently, both `LICENSE.txt` and `AUTHORS.txt` are included by setuptools by default, so all we need is to remove the manual `license_file` setting. This also fixes a build-time warning, since `license_file` is deprecated in favor of `license_files`.
SpecLad
force-pushed
the
authors-in-wheels
branch
from
5d4c325
to
2f153af
Compare
uranusjr
approved these changes
Mar 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wheels already include
LICENSE.txt, which refers toAUTHORS.txt, soAUTHORS.txtshould be included too.Conveniently, both
LICENSE.txtandAUTHORS.txtare included by setuptools by default, so all we need is to remove the manuallicense_filesetting.This also fixes a build-time warning, since
license_fileis deprecated in favor oflicense_files.