Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated pip install argument description #12417

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Fix outdated pip install argument description #12417

merged 4 commits into from
Nov 28, 2023

Conversation

xqm32
Copy link
Contributor

@xqm32 xqm32 commented Nov 28, 2023

Both pyproject.toml and setup.py will work, so we only need to contain one of them.

@uranusjr
Copy link
Member

Can you fix the line length to wrap similarly to other lines? Otherwises lgtm.

@uranusjr
Copy link
Member

A doc news fragment would also be nice. See documentation on how to create one.

@xqm32
Copy link
Contributor Author

xqm32 commented Nov 28, 2023

Hi @uranusjr, I have updated the doc and added a news entry, please help to review these changes, thanks!

news/12417.doc.rst Outdated Show resolved Hide resolved
@uranusjr uranusjr merged commit a15dd75 into pypa:main Nov 28, 2023
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants