Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut a 24.0.1 release that is compatible with Python 3.13 before vendoring new version of packaging #12619

Closed
1 task done
notatallshaw opened this issue Apr 12, 2024 · 4 comments
Labels
S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature

Comments

@notatallshaw
Copy link
Member

notatallshaw commented Apr 12, 2024

What's the problem this feature will solve?

When #12300 lands there will be packages that from that point on will likely be permanently incompatible with pip, e.g. textract, because they use legacy versions or specifiers.

Yet, this may be the only reason they are incompatible with Python 3.13+. However pip 24.0 is incompatible with Python 3.13 but main is not due to #12462 being merged after 24.0 was released.

This will allow the workaround for users, who do not have the ability to fork the relevant projects, on Python 3.13 to install pip==24.0.1

Describe the solution you'd like

  • Add Python 3.13 to the CI tests
  • Fix any issues
  • Release a 24.0.1 version of pip

Alternative Solutions

Advise users to either:

  • Fork the broken project
  • Use uv to install packages with legacy versions of specifiers

Additional context

This is to create a short/medium term workaround for users who get stuck because they are not technically proficient enough to fork and they are, for some reason, required to use Python 3.13.

This is not meant as a long term workaround, and could break for Python 3.14.

Code of Conduct

@notatallshaw notatallshaw added S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature labels Apr 12, 2024
@notatallshaw
Copy link
Member Author

btw, I'm happy to add the CI tests and fix any issues, I can take a look once I get home tonight.

@notatallshaw
Copy link
Member Author

notatallshaw commented Apr 13, 2024

First blocker I found for running tests, freezegun will need to do a release spulec/freezegun#534

@notatallshaw
Copy link
Member Author

notatallshaw commented Apr 13, 2024

I created #12620, it looks like while pip seems to run fine on Python 3.13, getting the whole CI test suite running will be at least a few weeks away.

@notatallshaw
Copy link
Member Author

Closing as #12300 (comment) suggests that #12462 is no longer a requirement to work on Python 3.13.

I will continue to work on updating Python 3.13 CI PR, but with this news it seems like a 24.0.1 is no longer required.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

1 participant