Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable self version check in PEP 517 pip subprocesses #12683

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

ichard26
Copy link
Member

@ichard26 ichard26 commented May 8, 2024

This eliminates a (very) small unnecessary performance penalty and reduces output clutter when the pip subprocess errors out.

This eliminates a (very) small unnecessary performance penalty and
reduces output clutter when the pip subprocess errors out.
@ichard26 ichard26 added this to the 24.2 milestone May 12, 2024
@ichard26
Copy link
Member Author

ichard26 commented Jul 2, 2024

This is a tiny low-risk patch, I'd love for it to be merged :)

@pfmoore pfmoore merged commit abde745 into pypa:main Jul 2, 2024
29 checks passed
@ichard26
Copy link
Member Author

ichard26 commented Jul 2, 2024

Thank you!

@ichard26 ichard26 deleted the disable-self-version-check-in-pep517 branch July 2, 2024 15:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants