Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to fix a non-fatal logging error in a debug log message in
freeze.py
(first commit out of the four in this PR).It also does the following related things:
PipTestEnvironment
to also check for logging errors whenallow_stderr_error
is false, and also add a test to check that this works. This will help to catch and prevent similar errors in the future.expect_stderr=True
arguments in VCS tests. (If (1) and (2) had been done before, the logging error would have been detected by the test suite.)expect_error=True
in some VCS tests. This unveiled a broken test (test_git_with_non_editable_unpacking
), which is also fixed in the fourth commit.Possible future change / improvement: also check for logging errors when our tests are running even if
allow_stderr_error
is true.