Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added copyright doc #7767

Merged
merged 5 commits into from
Mar 18, 2020
Merged

Added copyright doc #7767

merged 5 commits into from
Mar 18, 2020

Conversation

RDIL
Copy link
Contributor

@RDIL RDIL commented Feb 21, 2020

Signed-off-by: Reece Dunham [email protected]

fixes #7464

Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
@RDIL RDIL requested a review from pradyunsg February 21, 2020 22:51
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, barring one minor comment.

news/7767.doc Outdated Show resolved Hide resolved
@pradyunsg pradyunsg added type: docs Documentation related S: awaiting response Waiting for a response/more information labels Feb 22, 2020
Co-Authored-By: Pradyun Gedam <[email protected]>
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... Looks like the documentation build is failing because the copyright page isn't actually referenced directly anywhere.

Could you add a :orphan: on a separate line on the top?

Basically:

:orphan:

=====

@RDIL
Copy link
Contributor Author

RDIL commented Feb 22, 2020

Fixed, and all the docs related builds are passing!

@pradyunsg
Copy link
Member

Awesome! Looks like the failures are unrelated to this PR!

I'll take a look at them in a bit. :)

@pradyunsg pradyunsg merged commit 9e15cd4 into pypa:master Mar 18, 2020
@pradyunsg
Copy link
Member

Awesome! Thanks @RDIL!

@RDIL RDIL deleted the copyright-docs branch March 18, 2020 12:29
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Apr 18, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation S: awaiting response Waiting for a response/more information type: docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken "copyright" link in docs footer
4 participants