-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added copyright doc #7767
Added copyright doc #7767
Conversation
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, barring one minor comment.
Co-Authored-By: Pradyun Gedam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... Looks like the documentation build is failing because the copyright page isn't actually referenced directly anywhere.
Could you add a :orphan:
on a separate line on the top?
Basically:
:orphan:
=====
Fixed, and all the docs related builds are passing! |
Awesome! Looks like the failures are unrelated to this PR! I'll take a look at them in a bit. :) |
Awesome! Thanks @RDIL! |
Signed-off-by: Reece Dunham [email protected]
fixes #7464