-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escpace spaces on cmder shell path - Fixes #2115 #2168
Escpace spaces on cmder shell path - Fixes #2115 #2168
Conversation
This looks good, but would cause conflicts with #2161 (because I rewrote too many things). I’d want to push this in a 11.10.x bugfix release (if there is), and remember to apply this in 11.11. |
I think I'd rather rework this for 11.11 if it still applies |
As an additional note for this pr and for #2167 you will need to add a patch to |
👍 yes I am not proud of this one :)
done |
@gtalarico the rework comment is more with regard to the changes in #2161 |
This PR fixes #2115 by escaping space characters windows-style
%CMDER_ROOT%
The issue, which is detailed on #2115, happens when Cmder is running from a location which contains space characters.