New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in 2020.05.28 -- pipenv sync fails in Gitlab CI context #4272

Closed

freekwiekmeijer opened this issue May 28, 2020 · 2 comments

Labels

Type: Duplicate Type: Regression Type: Vendored Dependencies

freekwiekmeijer commented May 28, 2020

The following package requirement is broken:

[packages]
my_package_name = {git = "https://gitlab+deploy-token-8:[email protected]/path/to/project.git",editable = true,ref = "0.0.1_dev"}

In the logging of the gitlab CI server we see that the deploy token is represented as:

gitlab deploy-token-8

(notice that the '+' sign turned into a space).

pipenv sync fails on this package.

We went back to version pipenv==2018.11.26 and the CI job succeeds again.

triage-new-issues bot added the triage label

frostming added Type: Regression Type: Vendored Dependencies labels

triage-new-issues bot removed the triage label

frostming mentioned this issue

Don't encode/decode '+' in url auth part sarugaku/requirementslib#244

Merged

Contributor

GPHemsley commented May 28, 2020

This appears to be a dupe of #4271.

techalchemy added the Type: Duplicate label

Member

techalchemy commented May 28, 2020

Thanks for the report! I agree it is a duplicate -- closing in favor of #4271

techalchemy closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment