Remove yaspin spinner #5468
Merged
Remove yaspin spinner #5468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in favour of `rich.console.Console`.
This is in favor of rich.status.
This is in favor of rich.status
oz123
added
Type: Vendored Dependencies
This broke after importing cosole at the top level.
Use console.status instead.
matteius
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip uses rich to create spinner and print terminal colors. This PR migrates from yaspin which we ship
to rich spinners.
This is done now. A follow-up PR will bump vistir to 0.7.4 which actually allows removing yaspin from vendor.
However, this is currently blocked by requirementslib, which still needs vistir==0.7.0.