Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Nushell overlays #5603

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Switch to Nushell overlays #5603

merged 2 commits into from
Feb 12, 2023

Conversation

LiHRaM
Copy link
Contributor

@LiHRaM LiHRaM commented Feb 8, 2023

This adds support for Nushell overlays. See #5583 for info.

The issue

Nushell support is broken due to a change in the virtualenv package which expects users to load the file using overlays instead of the source command. See #5583 for info.

The fix

Changing the command from source to overlay use resolves the issue.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

This adds support for Nushell overlays. See pypa#5583 for info.
@LiHRaM LiHRaM marked this pull request as ready for review February 8, 2023 16:34
@oz123 oz123 merged commit 3e35f95 into pypa:main Feb 12, 2023
@LiHRaM LiHRaM deleted the patch-1 branch February 14, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants