Replaced vendored toml with tomli #5678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oz123
force-pushed
the
drop-vendor-toml
branch
4 times, most recently
from
faac22d
to
57967f6
Compare
Add a compat layer for using tomllib from STL which allows us to drop vendored toml library.
matteius
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading the package for gentoo I realized we can drop our copy
of toml.
It is quite a change, but hopefully it works.
Also, I stepped around the normal process and patched a vendored package directly (dparse).
This will break if someone reruns the vendor script. But since it's just us who take care of it, we
can live with it for now. I have submitted a request upstream for fixing this. Let's hope they act soon.