Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply patch for install_search_all_sources = True #5895

Merged
merged 5 commits into from
Sep 1, 2023

Conversation

matteius
Copy link
Member

Thank you for contributing to Pipenv!

The issue

A while back I broke install_search_all_sources = True and I've realized this patch.

The fix

Search scopes gets used for resolver and installer, but install we invoke pip interface. This gives a way to ensure index restricted packages for the resolver, but bypass that during install.

Fixes #5743
Fixes #5781

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@monkeyman192
Copy link

I pulled this branch and built it locally using python -m build --wheel. I then installed the current latest released pipenv build and added

[pipenv]
install_search_all_sources = true

to the bottom of my Pipfile, and then ran pipenv sync --dev, and it failed.
I then uninstalled the latest release and installed pipenv from the wheel I just built and it sync'd successfully, so I'd say this looks good, at least for this particular case.

@matteius matteius marked this pull request as ready for review August 31, 2023 02:33
@matteius matteius merged commit 4cf36f8 into main Sep 1, 2023
19 checks passed
@matteius matteius deleted the fix-install-search-all-sources branch September 1, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants