Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start testing installation against pip on master #1649

Closed
pganssle opened this issue Jan 27, 2019 · 1 comment
Closed

Start testing installation against pip on master #1649

pganssle opened this issue Jan 27, 2019 · 1 comment
Labels
Needs Discussion Issues where the implementation still needs to be discussed.

Comments

@pganssle
Copy link
Member

I think the problem in #1644 and possibly the problem in #1642 would have been detected way earlier and possibly fixed before a release if we had been testing against master on pip. I know pandas tests against master on all their dependencies, and that's a reliable source of pre-release bugs for dateutil. In dateutil I also test against master for the tzdata repo.

Considering that we have fairly unusual build requirements, we're very likely to be missed in pip's normal testing, so I think it's reasonable for us to run some intermittent tests where we're using the master branch of pip, just as an early warning.

I suspect this will be a bit more complicated than other "build against master" type builds, particularly because we need to make sure it's built against master in all the virtualenvs, but if we can do this I think we should.

@pganssle pganssle added the Needs Discussion Issues where the implementation still needs to be discussed. label Jan 27, 2019
@jaraco
Copy link
Member

jaraco commented Jan 27, 2019

I'm generally in favor. I think I'd like separate tests for latest stable pip plus pip on master. Whether this should happen as a pytest fixture or possibly as a separate tox env or some other mechanism I'm not yet sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion Issues where the implementation still needs to be discussed.
Projects
None yet
Development

No branches or pull requests

2 participants