-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints to setuptools #2345
Comments
Sounds good to me. Would you be interested in contributing such hints? Maybe start at something modest, like |
I'm also interested in giving a hand, given this would take quite some work. |
Perhaps I could write it up, but it might take some more time then. As you're building on If someone else wants to immerse themselves into this, I wouldn't mind. I'm still a bit behind type hinting my own codebase first anyways. |
It's not a very friendly interface to type hint though with all the |
Perhaps it's a good idea to use a stub file and annotate the |
That would have been my idea too. I'm pretty busy at the moment though and so I'm not sure I'd get to it anytime soon! |
Late versions of the setuptools test suite will run mypy checks on the code, but there are many failed checks. To run the checks, use
|
It might be useful to add that in the meantime stubs were developed in typeshed: python/typeshed#5762 It seems to be ready to be released, once it is released I think the issue can be closed. |
With Python 3.12 dropping disutils, setuptools' oldest python supported version now being 3.8 and the typeshed's setuptools stubs having matured a lot, what do you think about setuptools providing its own typing information? This is the
|
It seems that setuptools doesn't have type hints at the moment:
I think that adding type hints at least to the most common entrypoints (e.g.
setup
) would be great to have, considering that setuptools is quite an important part of the official Python ecosystem.The text was updated successfully, but these errors were encountered: