-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bdist_wheel failing with setuptools with bad wheel name #265
Comments
What's the name of your wheel? |
FYI, this is the regex used by pip: https://github.com/pypa/pip/blob/master/src/pip/_internal/wheel.py#L572 Way more lax indeed... |
Need more information. Can you point me to your project or at least give the name of the wheel name? |
@agronholm
The same works fine with wheel version <= 0.31.1 @benoit-pierre |
@OmSaran Can you verify that the fix works for you? |
@agronholm It works, thanks for the fix!! |
python setup.py bdist_wheel
uses bdist_wheel.py from wheel package. Since version 0.32.0 it no longer works with version names that does not match https://github.com/pypa/wheel/blob/master/wheel/wheelfile.py#L16:L19Version names not matching the above regex did not fail with older versions of wheel.
Also PEP 427 does not enforce using PEP 440 standard version names.
The text was updated successfully, but these errors were encountered: