Increase file size limit of MAMEToolkit

[M-J-Murray]

I would like to increase the size of my pypi repository from 60MB to 120MB (https://pypi.org/project/MAMEToolkit/#files). I have already filed a issue, and was told to make the relevant changes: pypi/warehouse#6197.

I have now made the changes, so I would like to request the file size limit to be increased.

[jamadden]

The packaging is going to work much better with the tools in the ecosystem now! Thanks for taking the time to look into that.

It's not clear to me that a limit increase is useful at this point though. A built source distribution doesn't include the system-specific compiled binary (correctly) and is quite small:

$ git clone https://github.com/M-J-Murray/MAMEToolkit
Cloning into 'MAMEToolkit'...
remote: Enumerating objects: 40, done.
...
$ cd ./MAMEToolkit/
$ touch binary/mame
$ python setup.py sdist bdist_wheel
...
$ tar -tf dist/MAMEToolkit-1.0.3.tar.gz | grep emulator/mame/mame
# nothing
$ ls -lh dist/MAMEToolkit-1.0.3.tar.gz
-rw-r--r-- 1 jmadden wheel 146K Jul 30 05:29 dist/MAMEToolkit-1.0.3.tar.gz

The binary distribution does include the binary file:

$ ls -lh dist/MAMEToolkit-1.0.3-py3-none-linux_x86_64.whl
-rw-r--r-- 1 jmadden wheel 166K Jul 30 05:29 dist/MAMEToolkit-1.0.3-py3-none-linux_x86_64.whl
$ unzip -l dist/MAMEToolkit-1.0.3-py3-none-linux_x86_64.whl | grep emulator/mame/mame
        0  07-30-2019 10:29   emulator/mame/mame

but PyPI doesn't allow uploading plain linux_x86_64 wheels, though, because no tool will install them:

$ twine upload -r testpypi dist/MAMEToolkit-1.0.3-py3-none-linux_x86_64.whl
Uploading distributions to https://test.pypi.org/legacy/
Uploading MAMEToolkit-1.0.3-py3-none-linux_x86_64.whl
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 181k/181k [00:01<00:00, 127kB/s]
NOTE: Try --verbose to see response content.
HTTPError: 400 Client Error: Binary wheel 'MAMEToolkit-1.0.3-py3-none-linux_x86_64.whl' has an unsupported platform tag 'linux_x86_64'. for url: https://test.pypi.org/legacy/

Or were you still working on making the binary manylinux-compatible? (There are plans to scan wheels claiming to be manylinux and ensure that they comply with that platform tag.)

[di]

Closing due to inactivity.

[M-J-Murray]

Hello, sorry for such a late response, I've only just gotten round to sorting this out over the last few days. Btw, the MAMEToolkit github repo doesn't contain a copy of a mame executable because it was too large to upload to github; it is currently 231MB in size.

@jamadden I've worked a lot the last few days to resolve the linux_x86_64 issue.
I setup a manylinux2010 centos 6 docker container using: https://github.com/pypa/python-manylinux-demo.
I then spend ages sorting out exactly what libraries and versions extra were required to compile MAME. Then once I was finally able to compile MAME on centos 6, I used auditwheel to repair the MAMEToolkit wheel from linux_x86_64 to manylinux2010_x86_64. So now it will be a lot more compatible with linux systems, and any extra required libraries will be installed with the MAMEToolkit library. The final wheel is about 90MB. Could you now, finally, increase my pypa limit?

[jamadden]

That's awesome!

The limit on pypi.org has been raised to 100MB.