Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependencies on Matplotlib #6375

Closed
David-OConnor opened this issue Aug 6, 2019 · 4 comments
Closed

Missing dependencies on Matplotlib #6375

David-OConnor opened this issue Aug 6, 2019 · 4 comments

Comments

@David-OConnor
Copy link

This likely affects other projects as well.

Warehouse data
requires_dist: null

from Matplotlib 3.1.1's dist-info/METADATA file:

Requires-Dist: cycler (>=0.10)
Requires-Dist: kiwisolver (>=1.0.1)
Requires-Dist: pyparsing (!=2.0.4,!=2.1.2,!=2.1.6,>=2.0.1)
Requires-Dist: python-dateutil (>=2.1)
Requires-Dist: numpy (>=1.11)
@David-OConnor
Copy link
Author

David-OConnor commented Aug 6, 2019

Found this related issue. From what I gather:

  • The requires_dist field takes info from whatever dist was uploaded first. Ie if it was a source-dist, it shows null.
  • There's no distinction between no dependencies, and can't-find-dependencies.
  • Package info on the warehouse won't be changed once set, even if incorrect.

Is this right? I may build an api to cache this; would be more appropriate in the json warehouse api, but I'll press if this is a won't-fix.

Can we consider all dependency info on the warehouse unreliable, or just ones that show null?

@David-OConnor
Copy link
Author

David-OConnor commented Aug 6, 2019

WIP

@di
Copy link
Member

di commented Aug 6, 2019

Can we consider all dependency info on the warehouse unreliable

Yes, see https://dustingram.com/articles/2018/03/05/why-pypi-doesnt-know-dependencies/, which was linked from #6226.

@di di closed this as completed Aug 6, 2019
@David-OConnor
Copy link
Author

David-OConnor commented Aug 7, 2019

Thanks. IMO this is not resolved and should be attacked by the warehouse. This is technically easy to fix - not find a perfect solution, but provide more accurate data than we currently have. Downloading the package, and checking the METADATA provides the correct info in most of the cases I've seen.

Python's an elegant language with a fucked packaging system - this is the perfect place to fix it. We will not resolve deps for all packages, but can do it for most.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants