Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIxes Typo #7

Merged
merged 1 commit into from
Feb 20, 2020
Merged

FIxes Typo #7

merged 1 commit into from
Feb 20, 2020

Conversation

DanEdens
Copy link
Contributor

Suggested by Balacij
Pull request

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (dev@05c8c6a). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev       #7   +/-   ##
======================================
  Coverage       ?   92.38%           
======================================
  Files          ?       48           
  Lines          ?     7105           
  Branches       ?        0           
======================================
  Hits           ?     6564           
  Misses         ?      541           
  Partials       ?        0
Impacted Files Coverage Δ
pyppeteer/page.py 86.84% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05c8c6a...077a34e. Read the comment docs.

Copy link

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@Granitosaurus
Copy link
Contributor

I'm generally against single typo PRs but we can just get over with this one for the sake of brevity.

@Granitosaurus Granitosaurus merged commit 8749df0 into pyppeteer:dev Feb 20, 2020
celestialhorizon pushed a commit to celestialhorizon/pyppeteer2 that referenced this pull request Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants