Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration file to drop dependency of world_iso and build_demand #827

Closed
davide-f opened this issue Aug 10, 2023 · 2 comments
Closed

Comments

@davide-f
Copy link
Member

Describe the feature you'd like to see

After #814 is solved, an interesting feature is to decouple the overloading of world_iso and its use in build_demand to characterize which nc file to load by country.
I personally believe that it is safer to decouple the two dependencies:

  • have 1 dictionary to clarify what countries are covered by each GEGIS nc file
  • have 1 dictionary to store the country classification that we desire

Currently we are adopting a unique dictionary for both and that hinders the flexibility of defining the regional scope of the different entries

@Tomkourou
Copy link
Contributor

Please assign me.

@davide-f
Copy link
Member Author

davide-f commented Dec 2, 2023

Closed by #822

@davide-f davide-f closed this as completed Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants