Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Installing pyRevitCLI after pyRevit 5 removes the currently installed .addin files #2368

Open
5 tasks done
Dre-Tas opened this issue Aug 20, 2024 · 6 comments
Open
5 tasks done
Labels
Command Line Utility (CLI) Issues related to pyRevit CLI tool [subsystem] Wiki Issues related to Wiki or Documentation [subsystem]

Comments

@Dre-Tas
Copy link
Contributor

Dre-Tas commented Aug 20, 2024

✈ Pre-Flight checks

  • I don't have SentinelOne antivirus installed (see above for the solution)
  • I have searched in the issues (open and closed) but couldn't find a similar issue
  • I have searched in the pyRevit Forum for similar issues
  • I already followed the installation troubleshooting guide thoroughly
  • I am using the latest pyRevit Version

🐞 Describe the bug

Hi all! Thank you so much for tackling the Revit 2025 issue so promptly. Much appreciated!

First thing I uninstallled the previous version of pyRevit that was installed on my machine (4.something). Then I downloaded the pyrevit-installers folder from what I believe is the correct link and I just went through installing the 2 exe files in the (pyRevit_5.0.0.24232_admin_signed.exe and pyRevit_CLI_5.0.0.24232_admin_signed.exe).
I’m not getting any error. Just when I open Revit 2025 I don’t get pyRevit in there.

I also tried with the non-admin installers (pyRevit_5.0.0.24232_signed.exe and pyRevit_CLI_5.0.0.24232_signed.exe) but still nothing.

In both cases, the installation seems to go through correctly till the end. No errors and/or error messages are popping up, but at the end, when I open Revit 2025 pyRevit is not there.

Is anyone else having the same issue?
Am I doing it wrong?

⌨ Error/Debug Message

the installation seems to go through correctly till the end. No errors and/or error messages are popping up, but at the end, when I open Revit 2025 pyRevit is not there.

♻️ To Reproduce

  1. Double click the 2 .exe files (pyRevit_5.0.0.24232_signed.exe and pyRevit_CLI_5.0.0.24232_signed.exe or the 2 admin ones), follow the prompt until installation finishes.
  2. Open Revit 2025
  3. pyRevit is not there

⏲️ Expected behavior

To see pyRevit in the Revit 2025 toolbar

🖥️ Hardware and Software Setup (please complete the following information)

pyRevit is not currently installed on my machine. I uninstalled it before trying to install the new version, in order to avoid any potential conflict.

Additional context

No response

@Dre-Tas Dre-Tas added the Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] label Aug 20, 2024
@sanzoghenzo
Copy link
Contributor

Hi @Dre-Tas,
Why are you installing both pyrevit and the cli? the cli is already included in the regular installer.

Can you try to uninstall everything and only install pyrevit?

@Dre-Tas
Copy link
Contributor Author

Dre-Tas commented Aug 21, 2024

@sanzoghenzo I don't know why I installed both 😅 I saw two installers and I assumed you had to install both. I didn't really see instructions on how to install it so I just tried.

Your suggestion was good! I uninstalled everything, deleted all the folders from %appdata% and then tried installing only pyRevit_5.0.0.24232_admin_signed.exe and it worked. I opened Revit 2025 and I had pyRevit there!
I then went on with some testing/troubleshooting that might be helpful for you guys and:

  • closed Revit and installed pyRevit_CLI_5.0.0.24232_admin_signed.exe and then reopened Revit, which resulted in not having pyRevit anymore;
  • I then uninstalled the CLI from the control panel and opened Revit again > still no pyRevit
  • I then uninstalled pyRevit 5 from the control panel and deleted all folders from %appdata% and reinstalled just pyRevit 5, opened Revit and it was there.

Not sure if/how this is helpful, but there you go ;)

@Dre-Tas Dre-Tas closed this as completed Aug 21, 2024
@sanzoghenzo
Copy link
Contributor

Thanks @Dre-Tas for your thorough investigation!

I will reopen this because there's something wrong in the pyrevit CLI installer, so it makes sense to keep track of it.

@sanzoghenzo sanzoghenzo reopened this Aug 21, 2024
@sanzoghenzo sanzoghenzo changed the title [Bug]: Installing pyRevit 5 doesn't work - no error messages popping up either [Bug]: Installing pyRevitCLI after pyRevit 5 removes the currently installed addins Aug 21, 2024
@sanzoghenzo sanzoghenzo changed the title [Bug]: Installing pyRevitCLI after pyRevit 5 removes the currently installed addins [Bug]: Installing pyRevitCLI after pyRevit 5 removes the currently installed .addin files Aug 21, 2024
@sanzoghenzo
Copy link
Contributor

I checked the PyRevitCLI installers, and this is by design: after the installation the following commands are run:

pyrevit caches clear --all
pyrevit detach --all

This is because the CLI installer is meant to be used to manually setup your pyrevit installation, so it makes sure you're starting from a clean slate.

I would leave it as it is, but maybe we can document better what the different installers are for.
A page on the notion site and a link of that page on the release message would suffice.

@sanzoghenzo sanzoghenzo added Wiki Issues related to Wiki or Documentation [subsystem] CI/CD Issues and PR related to the CI/CD workflow in github and removed Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] labels Aug 22, 2024
@acco-jpitts
Copy link
Contributor

@sanzoghenzo So you are saying the CLI should be functioning properly right now?

I tried swapping the first WIP 2025 installer into my deploy script and it was not working. I'll try again with the latest WIP, but I didn't see any relevant commits

@sanzoghenzo sanzoghenzo added Command Line Utility (CLI) Issues related to pyRevit CLI tool [subsystem] and removed CI/CD Issues and PR related to the CI/CD workflow in github labels Aug 24, 2024
@sanzoghenzo
Copy link
Contributor

@sanzoghenzo So you are saying the CLI should be functioning properly right now?

I tried swapping the first WIP 2025 installer into my deploy script and it was not working. I'll try again with the latest WIP, but I didn't see any relevant commits

I only meant that this particular issue is the expected behavior: installing the pyrevitCli (not the full pyrevit) will remove the previous pyrevit .addin files from all the revit instances, if any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Command Line Utility (CLI) Issues related to pyRevit CLI tool [subsystem] Wiki Issues related to Wiki or Documentation [subsystem]
Projects
None yet
Development

No branches or pull requests

3 participants