Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement distribution shape helpers to avoid need for dummy tensors #412

Closed
4 tasks done
fritzo opened this issue Dec 22, 2020 · 2 comments
Closed
4 tasks done

Implement distribution shape helpers to avoid need for dummy tensors #412

fritzo opened this issue Dec 22, 2020 · 2 comments

Comments

@fritzo
Copy link
Member

fritzo commented Dec 22, 2020

As mentioned in #402 (comment) we should add distribution methods upstream to perform all needed shape operations.

Currently Funsor's distribution shaping logic uses the pattern of creating fake distributions with dummy tensors to determine distribution event shape and batch shape. As a goal for Funsor use in Pyro 2.0, we should eliminate the need to ever instantiate a dummy tensor, and should eliminate the tensor shape caches.

Tasks

@eb8680
Copy link
Member

eb8680 commented Feb 23, 2021

Now that pyro-ppl/pyro#2739 has landed, what's left to do on the Funsor side?

@fritzo
Copy link
Member Author

fritzo commented Feb 23, 2021

I think it's safe to close this. Possible future tasks include:

@fritzo fritzo closed this as completed Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants