Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to ensure that environment.yml can install without error #63

Open
sgbaird opened this issue Jan 8, 2023 · 1 comment
Open

Test to ensure that environment.yml can install without error #63

sgbaird opened this issue Jan 8, 2023 · 1 comment

Comments

@sgbaird
Copy link
Contributor

sgbaird commented Jan 8, 2023

Describe your use-case

I've often found that the environment.yml file can't be successfully resolved when users first try out the repository in development mode (rather than installing the Python package directly). See for example sparks-baird/self-driving-lab-demo#164. I tend to keep setup.cfg up-to-date, but I'm not regularly checking environment.yml.

Describe the solution you would like to see for your use-case

It would be nice to add a step to GitHub actions that ensures the environment.yml file can be successfully installed. This could also be a step that only runs when environment.yml gets changed to reduce the overhead.

Alternatively, there could be a note in the README installation section to try:

conda create -n <name-of-package> python==3.10.*
pip install -e .

in case conda create -f environment.yml produces an error, and manually install additional packages from environment.yml as needed (e.g., for running notebooks).

@FlorianWilhelm
Copy link
Member

Hi @sgbaird, thanks for suggesting this improvement and sorry for my late reply.

In which cases does conda create -f environment.yml produce an error? Would this then rather be an error within the conda package repository itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants