Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing utils._toposort with the Python std. lib. TopologicalSorter #39

Open
majidaldo opened this issue Jan 29, 2023 · 1 comment
Open

Consider replacing utils._toposort with the Python std. lib. TopologicalSorter #39

majidaldo opened this issue Jan 29, 2023 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@majidaldo
Copy link

majidaldo commented Jan 29, 2023 •
edited by brandonwillard
Loading

Consider replacing

unification/unification/utils.py

Line 20 in 94e489e

def _toposort(edges):
with graphlib.TopologicalSorter.
@brandonwillard brandonwillard changed the title replace utils._toposort with std lib TopologicalSorter Consider replacing utils._toposort with the Python std. lib. TopologicalSorter Feb 1, 2023
@brandonwillard brandonwillard added question Further information is requested enhancement New feature or request labels Feb 1, 2023
@brandonwillard
Copy link
Member

We need to determine if TopologicalSorter could be worthwhile to adapt to this use-case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonwillard @majidaldo