Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExtraFieldsException #237

Closed
vedantpuri opened this issue Mar 23, 2022 · 3 comments
Closed

Add ExtraFieldsException #237

vedantpuri opened this issue Mar 23, 2022 · 3 comments

Comments

@vedantpuri
Copy link

  • cattrs version: 22.1.0.dev0
  • Python version: 3.7.5
  • Operating System: macOS Monterey (12.2.1)

Description

Trying to catch a specific exception for when extra fields are passed on the attrs class I am trying to construct. Right now the vanilla Exception is raised which I think should be made more specific.

What I Did

See #236

@Tinche
Copy link
Member

Tinche commented Mar 24, 2022

There's a PR to fix this: #225

@vedantpuri
Copy link
Author

Thats awesome!! Feel free to close this issue then, I haven't looked into the PR yet but it would be nice to make that Exception recursive too (so its easy to point to nested attrs classes when recursing through the exceptions)

@Tinche
Copy link
Member

Tinche commented Apr 5, 2022

This is done!

@Tinche Tinche closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants