fix subpackage check for setup.py generation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated failures in CI. |
kasteph
requested changes
Apr 9, 2020
| is_subpkg = any( | ||
| [filename.endswith(".py") for filename in filenames] | ||
| ) and not all( | ||
| [ |
There was a problem hiding this comment.
Could this be extracted out to a different variable to make it easier to read? It took me a while to understand that this was checking that all of the Python files are not part of the excluded files.
There was a problem hiding this comment.
I agree; but I wanted to keep this at par with the fix we have already merged in poetry pr. That might be a seperate change.
There was a problem hiding this comment.
Okay, makes sense. Then this PR looks good to go.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a forward port of python-poetry/poetry#1626.
Resolves: python-poetry/poetry#2283