Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sources and extras handling on packages and dependencies #78

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

sdispater
Copy link
Member

Resolves: python-poetry/poetry#2545
Resolves: python-poetry/poetry#2494
Resolves: python-poetry/poetry#2300
Resolves: python-poetry/poetry#2080
Resolves: python-poetry/poetry#1609

This is a preliminary work to solve the referenced issues on Poetry's end.

This PR refactors and improves the way packages and dependencies are compared to each other, by taking into account their source and their features/extras.

This the first step of a complete refactor of packages and sources that will be done in the 1.2 release of Poetry.

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater requested a review from a team September 3, 2020 21:55
@sdispater sdispater force-pushed the refactor-packages-dependencies branch from 863c13a to 69fc718 Compare September 3, 2020 22:00
Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like the direction we are heading in. Some comments.

poetry/core/factory.py Show resolved Hide resolved
poetry/core/factory.py Outdated Show resolved Hide resolved
poetry/core/factory.py Show resolved Hide resolved
poetry/core/packages/__init__.py Outdated Show resolved Hide resolved
poetry/core/packages/dependency.py Outdated Show resolved Hide resolved
poetry/core/packages/package_specification.py Outdated Show resolved Hide resolved
poetry/core/packages/package_specification.py Outdated Show resolved Hide resolved
@sdispater sdispater force-pushed the refactor-packages-dependencies branch from 69fc718 to c2d37ff Compare September 4, 2020 12:20
@sdispater sdispater force-pushed the refactor-packages-dependencies branch 2 times, most recently from 8baa9e1 to 60fd7b0 Compare September 6, 2020 18:26
@sdispater sdispater force-pushed the refactor-packages-dependencies branch 5 times, most recently from c670d7f to 0c18d81 Compare September 11, 2020 08:21
@abn
Copy link
Member

abn commented Sep 16, 2020

@sdispater LGTM one comment for offline discussion maybe is https://github.com/python-poetry/poetry-core/pull/78/files#r489371619

@abn abn requested a review from finswimmer September 16, 2020 11:50
@sdispater sdispater merged commit d640ff9 into master Sep 17, 2020
@sdispater sdispater deleted the refactor-packages-dependencies branch September 17, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants