Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Available settings are undocumented #223

Closed
cauebs opened this issue Jun 16, 2018 · 4 comments
Closed

Available settings are undocumented #223

cauebs opened this issue Jun 16, 2018 · 4 comments

Comments

@cauebs
Copy link
Contributor

cauebs commented Jun 16, 2018

As pointed out in #213, some settings are not yet documented.
I looked through the code and found these:

  • settings.pypi.fallback - boolean - Always put PyPI last to prefere private repositories (defaults to true)
  • settings.virtualenvs.create - boolean - Create a new virtualenv if one doesn't already exist (defaults to true?)
  • settings.virtualenvs.in-project - boolean - Create the project's virtualenv inside the project's directory (defaults to false?)
  • settings.virtualenvs.path - string - Directory where virtualenvs should be created (defaults to ~/.cache/pypoetry/virtualenvs?)
  • repository.<name> - string - Additional repository's URL

Now, did I miss any? Are these defaults really the defaults? And where should it be documented? Here?

If we can agree on a way to present these informations, I'd be happy to work on a PR :)

@sdispater
Copy link
Member

I think we can make a new documentation section, "Configuration", where we list the settings available with an example of how to set them.

Regarding settings.pypi.fallback, it actually configures the behavior of the resolver when it can't find the information it needs from the PyPI JSON API. If it's activated (the default) it will fallback to downloading and inspecting the package distributions (sdist or wheels) to find information about the package's dependencies. This was introduced early in development to make the resolution faster, albeit much less accurate, when the resolver was less efficient. However, I think we can remove it now that the resolver is much smarter and, to be completely honest, it's not that useful since deactivating it will make the resolver miss a lot of information.

@cauebs
Copy link
Contributor Author

cauebs commented Jun 18, 2018

@sdispater I think tonight I'll start working on this section ;)

@cauebs
Copy link
Contributor Author

cauebs commented Jun 19, 2018

Wouldn't it be interesting to add this list to the config command as well?

Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants