install-poetry.py doesn't exit with proper status code when installation fails

[mkniewallner]

• I am on the latest Poetry version. Not applicable, as it's on the installer

• I have searched the issues of this repo and believe that this is not a duplicate.

• If an exception occurs when executing a command, I executed it again in debug mode (-vvv option). Not applicable, as it's on the installer

• OS version and name: ArchLinux and Debian 11

Issue

install-poetry.py doesn't exit with the proper exit code if the installation of Poetry using pip failed.
This is due to subprocess.run command in install_poetry not using check=True to make sure that an exception is raised if the output returned with an exit code other than 0:

poetry/install-poetry.py

Lines 584 to 588 in c967a4a

	subprocess.run(
	[str(python), "-m", "pip", "install", specification],
	stdout=subprocess.PIPE,
	stderr=subprocess.STDOUT,
	)

See documentation for subprocess.run https://docs.python.org/3/library/subprocess.html#subprocess.run

If check is true, and the process exits with a non-zero exit code, a CalledProcessError exception will be raised.

Reproducibility

To showcase the issue (and also show what the expected behaviour should be with a fix), I've created a dedicated repository with 2 Dockerfile that GitHub Actions ran on: https://github.com/mkniewallner/showcase-poetry-installer-issue

In the workflow, two jobs have been defined:

• poetry-master: Tries to install poetry using Python 3.10.0rc1 via install-poetry.py from python-poetry/poetry repository
• poetry-with-fix: Tries to install poetry using Python 3.10.0rc1 via install-poetry.py from mkniewallner/poetry repository on a commit containg a potential fix

On both jobs, it wasn't possible to install Poetry because of missing system dependencies for cffi module, but:

• on poetry-master, the step that tries to install Poetry doesn't return with a non-zero exit code, as it run poetry --version just after (see logs)
• on poetry-with-fix, the step that tries to install Poetry correctly returns with a non-zero exit code, displays the error that happened, and doesn't run poetry --version just after, as the installation failed so it ends the workflow early (see logs)

[finswimmer]

Thanks a lot for the detailed issue report, problem analysis and solution suggestion 👍 Would like to see more of them 😃

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.