Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: poetry install fails with a build script due to not respecting [build-system] requires #7909

Closed
4 tasks done
Samreay opened this issue May 12, 2023 · 5 comments
Closed
4 tasks done
Labels
area/build-system Related to PEP 517 packaging (see poetry-core) kind/bug Something isn't working as expected status/duplicate Duplicate issues

Comments

@Samreay
Copy link

Samreay commented May 12, 2023

  • I am on the latest stable Poetry version, installed using a recommended method.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have consulted the FAQ and blog for any relevant entries or release notes.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

This issue may be linked to:

This issue might actually be setuptools rather than poetry as well. I'm not sure how the two libraries interact with each other.

We noticed that our latest builds are failing on our poetry install. Our project has cython code, and so part of our build.py that's referenced by the [tool.poetry.build] is to use numpy and cython (which are part of the [build-system].requires section) to compile the cython code into binaries.

Now, a poetry build works as expected, because it installs the build dependencies. But a poetry install on longer works

image
image

To summarise the above images:

  1. numpy is defined in both the [tool.poetry.dependencies] and [build-system].requires
  2. poetry build runs and compiles files successfully
  3. poetry install fails on: Getting requirements to build editable did not run successfully. as poetry/setuptools tries to run our builder.py without dependencies, which fails.

Now the big caveat here, is that I don't know how poetry and setuptools interact, so this might have absolutely nothing to do with poetry and everything to do with setuptools. In which case, please feel free to close out this issue and I'll try to raise it somewhere else.

Has the way to include a build script that has dependencies changed in the latest poetry versions?

@Samreay Samreay added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels May 12, 2023
@dimbleby
Copy link
Contributor

not only "linked" to #6154 but surely a straight duplicate

@Samreay
Copy link
Author

Samreay commented May 12, 2023

I was unsure if it was a duplicate or not, because I've definitely had poetry building my project after that issue was posted, and its only in the last two months that the build stage we've had has failed. Given the other issue doesn't include the full stack I also wasn't sure if the issue was from the same part of the code. If you like, I can put the screenshots and pyproject.toml over onto that issue, I just didn't want to do so if it might have been a different problem

@dimbleby
Copy link
Contributor

dimbleby commented May 12, 2023

you've described the same circumstances, the same actions, and the same symptoms - I think assuming duplicate is sensible.

By all means add extra information to that issue if you think you have something new to add (though please prefer text to screenshots, so much less annoying to interact with and search)

@radoering radoering added area/build-system Related to PEP 517 packaging (see poetry-core) status/duplicate Duplicate issues and removed status/triage This issue needs to be triaged labels Jun 10, 2023
@radoering
Copy link
Member

Closing as duplicate of #6154

@radoering radoering closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/build-system Related to PEP 517 packaging (see poetry-core) kind/bug Something isn't working as expected status/duplicate Duplicate issues
Projects
None yet
Development

No branches or pull requests

3 participants