-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default for the include flag is sdist only, not sdist AND wheel #8698
Comments
the best way to make docs changes happen is to submit merge requests! your question about where files should live seems like more of a question about how python modules work at all, than about how poetry builds packages, I'm doubtful that poetry should take responsibility for documenting that. |
Fair enough - I think the reason for not making the change myself is because I don't know what the correct default behaviour should be. Happy to make the change myself if it is just change to "If no format is specified, it will default to include only sdist". On the general Python questions, yes I agree this is largely outside of the Poetry remit. I think the poetry-relevant bit (which I admit I didn't make clear in my original post) is that Poetry will include those files in the |
I assume that making the documentation match the code is uncontroversial and just a clear improvement: even if a later fix decides to change both. If you or anyone else does think that it is the code that is wrong I suppose this is the relevant line |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Issue
I was hitting a bunch of issues trying to include resource files in my Poetry build using the
include
key. It turns out that despite the docs saying thatIt in fact seems to default to only
sdist
. The workaround was to changeto
In addition to this, I find the documentation unclear / challenging in terms of understanding how to access these files when pulling the package in as a dependency. If the files aren't included in the module, I am struggling to get
importlib.resources
to work.If it is required that files the package needs to access live inside the package folder, please could this be added to the documentation? If not, could you add some guidance on this?
The text was updated successfully, but these errors were encountered: