You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi. As mentioned in this Test Suite Cleanup issue, there might be some code needing coverage, yet running poetry run pytest doesn't tell the coverage. I'd like to contribute to this task by first adding a coverage report that everyone can see locally and in CI.
Impact
Rendering a coverage report by running the tests.
Workarounds
N/A
The text was updated successfully, but these errors were encountered:
In CI, the challenge is to create coverage reports for all Python versions and platforms and combine the results. Further, we should keep an eye on runtimes (how much slower tests become with coverage).
Since we have pytest-cov plugin, I think seeing local coverage would be as simple as running poetry run pytest --cov=src/poetry --cov-report term. I would be all for adding the coverage report on CI, but since GH doesn't support reading coverage report files from CI, that would have to be hacked around, outsourced to another service (like codecov), or would only be visible when browsing CI logs, which expire after some time. Overall, it's not worth the work needed and the maintenance burden.
I agree that info about how to see coverage locally should be added to contributing docs, but nothing beyond that.
Issue Kind
Brand new capability
Description
Hi. As mentioned in this Test Suite Cleanup issue, there might be some code needing coverage, yet running
poetry run pytest
doesn't tell the coverage. I'd like to contribute to this task by first adding a coverage report that everyone can see locally and in CI.Impact
Rendering a coverage report by running the tests.
Workarounds
N/A
The text was updated successfully, but these errors were encountered: