poetry lock --no-update updates dependencies if custom source specified

[maxim-krikun]

• I am on the latest Poetry version.
• I have searched the issues of this repo and believe that this is not a duplicate.
• If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

• OS version and name: Windows 10 (21H2)
• Poetry version: 1.2.0
• Link of a Gist with the contents of your pyproject.toml file:

Issue

Using Poetry 1.1.14 and lock file poetry_1.1.14.lock:

❯ poetry lock --no-update
Resolving dependencies...

The lock file remains unchanged. Then upgrade Poetry up to 1.2.0.
Using Poetry 1.2.0 and lock file poetry_1.1.14.lock:

❯ poetry lock --check
poetry.lock is consistent with pyproject.toml.
❯ poetry lock --no-update
Resolving dependencies...

Writing lock file

It produces a new lock file poetry_1.2.0.lock.
As you can see some versions of the dependencies have been updated.
That is, the changes were not only cosmetic.
I'd also like to note:

• if you don't use a custom source (just remove source block from pyproject.toml and repeat repro steps), everything works as it should;
• command for checking lock file returned a positive result. So there must be a bug somewhere, either in the check or in the locking.

[dimbleby]

poetry/src/poetry/puzzle/provider.py

Line 846 in a613347

and dependency.is_same_source_as(package)

I think is the line that refuses to acknowledge that the locked package is the same as the dependency - because the dependency has no source_type or source_url, whereas the locked package does.

poetry 1.1 used to ask a slightly different question:

poetry/poetry/mixology/version_solver.py

Line 469 in 46bf7fd

if not dependency.is_same_package_as(locked):

.

I think that it is python-poetry/poetry-core#325 which introduced the changed behaviour, though refactorings since then have made the trail not quite straightforward to follow.

I guess we need a more delicate check on the source type here.

[dimbleby]

(probably #6307 was the same, but it's amazing the difference a repro makes - thank you!)

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.