Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-547 http header quality factor number #552

Merged
merged 1 commit into from
Jul 13, 2023
Merged

issue-547 http header quality factor number #552

merged 1 commit into from
Jul 13, 2023

Conversation

thefunkinator
Copy link
Contributor

Proposed changes

Change in Werkzeug 2.3.5 as issued here caused the fail in build. As per HTTP RFC the quality-factor for HTTP Accept Header has to be like X.X. So changing them all to such format, all Unit tests and Tox test passes.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the guidelines for contributing
  • All unit tests pass on my local version with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Fixes #547

Copy link
Contributor

@peter-doggart peter-doggart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@peter-doggart peter-doggart merged commit b1e5d19 into python-restx:master Jul 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_media_types_method - Test failure
2 participants