Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BaseResponse import - replace wekzeug import __version__ by importlib (#573) #575

Merged
merged 5 commits into from
Dec 10, 2023

Conversation

Ryu-CZ
Copy link
Contributor

@Ryu-CZ Ryu-CZ commented Oct 6, 2023

Fix for removed wekzeug.__version__ #573 and Logical follow up to replacement of pkg_resources replacement #562 .

Design decision: I decided to create separate import function import_werkzeug_response to do not mess up with global import space with import werkzeug in case of future version conflicts. BaseResponse is now imported once within flask_restx.utils module internally with method import_werkzeug_response and accessible as flask_restx.utils.BaseResponse .

@Ryu-CZ Ryu-CZ force-pushed the werkzeug-importlib-573 branch 2 times, most recently from 5730306 to 84b893d Compare October 25, 2023 11:37
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b7d1ded) 96.15% compared to head (b5d7b70) 96.15%.

Files Patch % Lines
flask_restx/utils.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #575   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files          20       20           
  Lines        2755     2756    +1     
=======================================
+ Hits         2649     2650    +1     
  Misses        106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peter-doggart peter-doggart merged commit a65dbe7 into python-restx:master Dec 10, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants