-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.21.1: pep517 build packages docs/ content #271
Comments
Hi @kloczek, what do you mean by If you build package using $ [validators-0.21.1-py3-none-any] ls -laR
Permissions Size User Date Modified Name
drwxr-xr-x - us-er 26 Apr 08:16 docs
drwxr-xr-x - us-er 26 Apr 08:16 validators
drwxr-xr-x - us-er 26 Apr 08:16 validators-0.21.1.dist-info
.rw-r--r-- 9.8k us-er 1 Jan 1980 CHANGES.md
./docs:
Permissions Size User Date Modified Name
.rw-r--r-- 1.6k us-er 1 Jan 1980 conf.py
.rw-r--r-- 5.5k us-er 1 Jan 1980 gen_docs.py
.rw-r--r-- 1.5k us-er 1 Jan 1980 index.md
.rwxr-xr-x 1.5k us-er 1 Jan 1980 index.rst
.rw-r--r-- 800 us-er 1 Jan 1980 make.bat
.rw-r--r-- 634 us-er 1 Jan 1980 Makefile
.rwxr-xr-x 36k us-er 1 Jan 1980 validators.1
./validators:
Permissions Size User Date Modified Name
drwxr-xr-x - us-er 26 Apr 08:16 i18n
.rw-r--r-- 1.4k us-er 1 Jan 1980 __init__.py
.rw-r--r-- 1.1k us-er 1 Jan 1980 _extremes.py
.rw-r--r-- 3.2k us-er 1 Jan 1980 between.py
.rw-r--r-- 1.7k us-er 1 Jan 1980 btc_address.py
.rw-r--r-- 6.3k us-er 1 Jan 1980 card.py
.rw-r--r-- 1.8k us-er 1 Jan 1980 domain.py
.rw-r--r-- 2.8k us-er 1 Jan 1980 email.py
.rw-r--r-- 3.6k us-er 1 Jan 1980 hashes.py
.rw-r--r-- 3.7k us-er 1 Jan 1980 hostname.py
.rw-r--r-- 1.1k us-er 1 Jan 1980 iban.py
.rw-r--r-- 3.5k us-er 1 Jan 1980 ip_address.py
.rw-r--r-- 1.2k us-er 1 Jan 1980 length.py
.rw-r--r-- 948 us-er 1 Jan 1980 mac_address.py
.rw-r--r-- 0 us-er 1 Jan 1980 py.typed
.rw-r--r-- 845 us-er 1 Jan 1980 slug.py
.rw-r--r-- 6.5k us-er 1 Jan 1980 url.py
.rw-r--r-- 2.4k us-er 1 Jan 1980 utils.py
.rw-r--r-- 1.1k us-er 1 Jan 1980 uuid.py
./validators/i18n:
Permissions Size User Date Modified Name
.rw-r--r-- 234 us-er 1 Jan 1980 __init__.py
.rw-r--r-- 5.6k us-er 1 Jan 1980 es.py
.rw-r--r-- 3.2k us-er 1 Jan 1980 fi.py
./validators-0.21.1.dist-info:
Permissions Size User Date Modified Name
.rw-r--r-- 1.1k us-er 1 Jan 1980 LICENSE
.rw-r--r-- 2.8k us-er 1 Jan 1980 METADATA
.rw-r--r-- 2.5k us-er 1 Jan 2016 RECORD
.rw-r--r-- 88 us-er 1 Jan 1980 WHEEL |
These were the content of MANIFEST.in:
Commit 6bd8751, overrides it with the configuration in Line 43 in 506d22b
Do you want to include these in include = ["README.md", "LICENSE", "CHANGES.md", "docs/*", "tests/*"] |
Please try to build .whl archove using
This meand that those files will be included in .whl archive an dinstalled on use --- a/pyproject.toml
+++ b/pyproject.toml
@@ -40,7 +40,7 @@
"Programming Language :: Python :: Implementation :: CPython",
"Topic :: Software Development :: Libraries :: Python Modules",
]
-include = ["CHANGES.md", "docs/*", "docs/validators.1", "validators/py.typed"]
+include = ["validators/py.typed"]
#################### |
|
Becauseuse pep517 build executed that way will look always the same doesn't matter which one pep517 bakednd will be used. Yes 'build` is not part of the base putone modules and needs to be installed.
Please try to install that .whl using pep517 is new build procddure. |
My build backed is Lines 9 to 13 in 506d22b
I commented out the following in # include = ["README.md", "LICENSE", "CHANGES.md", "docs/*", "tests/*"]
Then I did, but what am I looking for? $ ls -la
Permissions Size User Date Modified Name
drwxr-xr-x - us-er 26 Apr 14:50 .venv
.rw-r--r-- 23k us-er 26 Apr 14:50 validators-0.21.1-py3-none-any.whl
$ pip install validators-0.21.1-py3-none-any.whl
Processing ./validators-0.21.1-py3-none-any.whl
Installing collected packages: validators
Successfully installed validators-0.21.1
$ pip list
Package Version
---------- -------
pip 23.1.1
setuptools 67.7.2
validators 0.21.1
$ ls -la .venv/lib/python3.8/site-packages/
Permissions Size User Date Modified Name
drwxr-xr-x - us-er 26 Apr 14:51 _distutils_hack
drwxr-xr-x - us-er 26 Apr 14:51 pip
drwxr-xr-x - us-er 26 Apr 14:51 pip-23.1.1.dist-info
drwxr-xr-x - us-er 26 Apr 14:51 pkg_resources
drwxr-xr-x - us-er 26 Apr 14:51 setuptools
drwxr-xr-x - us-er 26 Apr 14:51 setuptools-67.7.2.dist-info
drwxr-xr-x - us-er 26 Apr 14:51 validators
drwxr-xr-x - us-er 26 Apr 14:51 validators-0.21.1.dist-info
.rw-r--r-- 151 us-er 26 Apr 14:51 distutils-precedence.pth
$ ls -la .venv/lib/python3.8/site-packages/validators/
Permissions Size User Date Modified Name
drwxr-xr-x - us-er 26 Apr 14:51 __pycache__
drwxr-xr-x - us-er 26 Apr 14:51 i18n
.rw-r--r-- 1.4k us-er 26 Apr 14:51 __init__.py
.rw-r--r-- 1.1k us-er 26 Apr 14:51 _extremes.py
.rw-r--r-- 3.2k us-er 26 Apr 14:51 between.py
.rw-r--r-- 1.7k us-er 26 Apr 14:51 btc_address.py
.rw-r--r-- 6.3k us-er 26 Apr 14:51 card.py
.rw-r--r-- 1.8k us-er 26 Apr 14:51 domain.py
.rw-r--r-- 2.8k us-er 26 Apr 14:51 email.py
.rw-r--r-- 3.6k us-er 26 Apr 14:51 hashes.py
.rw-r--r-- 3.7k us-er 26 Apr 14:51 hostname.py
.rw-r--r-- 1.1k us-er 26 Apr 14:51 iban.py
.rw-r--r-- 3.5k us-er 26 Apr 14:51 ip_address.py
.rw-r--r-- 1.2k us-er 26 Apr 14:51 length.py
.rw-r--r-- 948 us-er 26 Apr 14:51 mac_address.py
.rw-r--r-- 0 us-er 26 Apr 14:51 py.typed
.rw-r--r-- 845 us-er 26 Apr 14:51 slug.py
.rw-r--r-- 6.5k us-er 26 Apr 14:51 url.py
.rw-r--r-- 2.4k us-er 26 Apr 14:51 utils.py
.rw-r--r-- 1.1k us-er 26 Apr 14:51 uuid.py
If so, then why not use PEP 517 is a specification that decouples frontends and backends in Python packaging. You can refer this talk What does PEP 517 mean for packaging. The goal was to "dethrone distutils and setuptools as the single blessed way of making Python packages." On another note, you're typing like an email spammer. |
There are two possibilies of include/exclude.
Into destdir passed as param for
Which one
Because in exact case you need to know first that exct module uses for example
What you mean? 😋 |
Are you looking for this? include = [
{ path = "CHANGES.md", format = "sdist" },
{ path = "docs/*", format = "sdist" },
{ path = "tests/*", format = "sdist" },
] ref: https://python-poetry.org/docs/pyproject#include-and-exclude
$ ls -laR ./validators-0.21.1/
Permissions Size User Date Modified Name
drwxr-xr-x - us-er 27 Apr 08:36 docs
drwxr-xr-x - us-er 27 Apr 08:36 tests
drwxr-xr-x - us-er 27 Apr 08:36 validators
.rw-r--r-- 9.8k us-er 12 Apr 19:02 CHANGES.md
.rw-r--r-- 1.1k us-er 31 Mar 21:39 LICENSE
.rw-r--r-- 2.8k us-er 1 Jan 1970 PKG-INFO
.rw-r--r-- 3.9k us-er 27 Apr 08:34 pyproject.toml
.rw-r--r-- 1.5k us-er 31 Mar 21:39 README.md
./validators-0.21.1/docs:
Permissions Size User Date Modified Name
.rw-r--r-- 1.6k us-er 31 Mar 21:39 conf.py
.rw-r--r-- 5.5k us-er 24 Apr 15:34 gen_docs.py
.rw-r--r-- 1.5k us-er 27 Apr 08:36 index.md
.rw-r--r-- 1.5k us-er 27 Apr 08:36 index.rst
.rw-r--r-- 800 us-er 31 Mar 21:39 make.bat
.rw-r--r-- 634 us-er 31 Mar 21:39 Makefile
.rwxr-xr-x 36k us-er 27 Apr 08:36 validators.1
./validators-0.21.1/tests:
Permissions Size User Date Modified Name
drwxr-xr-x - us-er 27 Apr 08:36 i18n
.rw-r--r-- 57 us-er 31 Mar 21:39 __init__.py
.rw-r--r-- 1.4k us-er 31 Mar 21:39 test__extremes.py
.rw-r--r-- 1.1k us-er 31 Mar 21:39 test_between.py
.rw-r--r-- 1.2k us-er 31 Mar 21:39 test_btc_address.py
.rw-r--r-- 4.4k us-er 31 Mar 21:39 test_card.py
.rw-r--r-- 1.9k us-er 31 Mar 21:39 test_domain.py
.rw-r--r-- 1.5k us-er 31 Mar 21:39 test_email.py
.rw-r--r-- 4.3k us-er 31 Mar 21:39 test_hashes.py
.rw-r--r-- 2.6k us-er 31 Mar 21:39 test_hostname.py
.rw-r--r-- 580 us-er 31 Mar 21:39 test_iban.py
.rw-r--r-- 2.6k us-er 31 Mar 21:39 test_ip_address.py
.rw-r--r-- 853 us-er 31 Mar 21:39 test_length.py
.rw-r--r-- 848 us-er 31 Mar 21:39 test_mac_address.py
.rw-r--r-- 708 us-er 31 Mar 21:39 test_slug.py
.rw-r--r-- 6.6k us-er 12 Apr 19:02 test_url.py
.rw-r--r-- 965 us-er 31 Mar 21:39 test_uuid.py
.rw-r--r-- 959 us-er 31 Mar 21:39 test_validation_failure.py
./validators-0.21.1/tests/i18n:
Permissions Size User Date Modified Name
.rw-r--r-- 61 us-er 31 Mar 21:39 __init__.py
.rw-r--r-- 2.8k us-er 31 Mar 21:39 test_es.py
.rw-r--r-- 2.1k us-er 31 Mar 21:39 test_fi.py
./validators-0.21.1/validators:
Permissions Size User Date Modified Name
drwxr-xr-x - us-er 27 Apr 08:36 i18n
.rw-r--r-- 1.4k us-er 12 Apr 19:02 __init__.py
.rw-r--r-- 1.1k us-er 31 Mar 21:39 _extremes.py
.rw-r--r-- 3.2k us-er 31 Mar 21:39 between.py
.rw-r--r-- 1.7k us-er 31 Mar 21:39 btc_address.py
.rw-r--r-- 6.3k us-er 31 Mar 21:39 card.py
.rw-r--r-- 1.8k us-er 31 Mar 21:39 domain.py
.rw-r--r-- 2.8k us-er 31 Mar 21:39 email.py
.rw-r--r-- 3.6k us-er 31 Mar 21:39 hashes.py
.rw-r--r-- 3.7k us-er 31 Mar 21:39 hostname.py
.rw-r--r-- 1.1k us-er 31 Mar 21:39 iban.py
.rw-r--r-- 3.5k us-er 31 Mar 21:39 ip_address.py
.rw-r--r-- 1.2k us-er 31 Mar 21:39 length.py
.rw-r--r-- 948 us-er 31 Mar 21:39 mac_address.py
.rw-r--r-- 0 us-er 31 Mar 21:39 py.typed
.rw-r--r-- 845 us-er 31 Mar 21:39 slug.py
.rw-r--r-- 6.5k us-er 12 Apr 19:02 url.py
.rw-r--r-- 2.4k us-er 31 Mar 21:39 utils.py
.rw-r--r-- 1.1k us-er 31 Mar 21:39 uuid.py
./validators-0.21.1/validators/i18n:
Permissions Size User Date Modified Name
.rw-r--r-- 234 us-er 31 Mar 21:39 __init__.py
.rw-r--r-- 5.6k us-er 31 Mar 21:39 es.py
.rw-r--r-- 3.2k us-er 31 Mar 21:39 fi.py
$ ls -laR ./validators-0.21.1-py3-none-any/
Permissions Size User Date Modified Name
drwxr-xr-x - us-er 27 Apr 08:39 validators
drwxr-xr-x - us-er 27 Apr 08:39 validators-0.21.1.dist-info
./validators-0.21.1-py3-none-any/validators:
Permissions Size User Date Modified Name
drwxr-xr-x - us-er 27 Apr 08:39 i18n
.rw-r--r-- 1.4k us-er 1 Jan 1980 __init__.py
.rw-r--r-- 1.1k us-er 1 Jan 1980 _extremes.py
.rw-r--r-- 3.2k us-er 1 Jan 1980 between.py
.rw-r--r-- 1.7k us-er 1 Jan 1980 btc_address.py
.rw-r--r-- 6.3k us-er 1 Jan 1980 card.py
.rw-r--r-- 1.8k us-er 1 Jan 1980 domain.py
.rw-r--r-- 2.8k us-er 1 Jan 1980 email.py
.rw-r--r-- 3.6k us-er 1 Jan 1980 hashes.py
.rw-r--r-- 3.7k us-er 1 Jan 1980 hostname.py
.rw-r--r-- 1.1k us-er 1 Jan 1980 iban.py
.rw-r--r-- 3.5k us-er 1 Jan 1980 ip_address.py
.rw-r--r-- 1.2k us-er 1 Jan 1980 length.py
.rw-r--r-- 948 us-er 1 Jan 1980 mac_address.py
.rw-r--r-- 0 us-er 1 Jan 1980 py.typed
.rw-r--r-- 845 us-er 1 Jan 1980 slug.py
.rw-r--r-- 6.5k us-er 1 Jan 1980 url.py
.rw-r--r-- 2.4k us-er 1 Jan 1980 utils.py
.rw-r--r-- 1.1k us-er 1 Jan 1980 uuid.py
./validators-0.21.1-py3-none-any/validators/i18n:
Permissions Size User Date Modified Name
.rw-r--r-- 234 us-er 1 Jan 1980 __init__.py
.rw-r--r-- 5.6k us-er 1 Jan 1980 es.py
.rw-r--r-- 3.2k us-er 1 Jan 1980 fi.py
./validators-0.21.1-py3-none-any/validators-0.21.1.dist-info:
Permissions Size User Date Modified Name
.rw-r--r-- 1.1k us-er 1 Jan 1980 LICENSE
.rw-r--r-- 2.8k us-er 1 Jan 1980 METADATA
.rw-r--r-- 1.9k us-er 1 Jan 2016 RECORD
.rw-r--r-- 88 us-er 1 Jan 1980 WHEEL |
Fixed in #283 |
wheel archive generetaed by:
And it has content:
Looks like MANIFEST.in files needs to be aded
The text was updated successfully, but these errors were encountered: