You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a number of tests that check various aspects of memory management, typically related to some specific module or feature. Nearly every one of these tests is fairly tightly coupled to the fine details of our memory management implementation, usually tied to specific numbers.
This makes the tests fragile, often breaking with even slight changes to some aspect of memory management. 1
mainly because they count allocations/test out of memory situations, and the hashtable adds random allocations which breaks their careful calculations.
Ideally, we would find a way to make such tests less coupled to specific numbers, without sacrificing the accuracy of the behavior checks they are making.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Footnotes
To be fair, we don't make changes to memory management very often; clearly these tests aren't breaking all the time. ↩
Note that those aren't necessarily the only tests that need attention here. ↩
The text was updated successfully, but these errors were encountered:
Feature or enhancement
Proposal:
There are a number of tests that check various aspects of memory management, typically related to some specific module or feature. Nearly every one of these tests is fairly tightly coupled to the fine details of our memory management implementation, usually tied to specific numbers.
This makes the tests fragile, often breaking with even slight changes to some aspect of memory management. 1
For example, in #121134 (comment), @Fidget-Spinner says:
2
Ideally, we would find a way to make such tests less coupled to specific numbers, without sacrificing the accuracy of the behavior checks they are making.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Footnotes
To be fair, we don't make changes to memory management very often; clearly these tests aren't breaking all the time. ↩
Note that those aren't necessarily the only tests that need attention here. ↩
The text was updated successfully, but these errors were encountered: