pathlib.WindowsPath.resolve() test expects short path

[zooba]

BPO	28995
Nosy	@pfmoore, @tjguk, @zware, @zooba

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2016-12-17.00:09:00.805>
labels = ['3.7', 'type-bug', 'tests', 'OS-windows']
title = 'pathlib.WindowsPath.resolve() test expects short path'
updated_at = <Date 2016-12-17.00:09:00.805>
user = 'https://github.com/zooba'

bugs.python.org fields:

activity = <Date 2016-12-17.00:09:00.805>
actor = 'steve.dower'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests', 'Windows']
creation = <Date 2016-12-17.00:09:00.805>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 28995
keywords = ['3.6regression']
message_count = 1.0
messages = ['283452']
nosy_count = 4.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue28995'
versions = ['Python 3.6', 'Python 3.7']

[zooba]

With bpo-19717, WindowsPath.resolve() now properly resolves the filename using the Windows APIs.

However, this may cause parts of the path to be replaced with their full name when provided as the 8.3 short name. The test was not updated for this:

Traceback (most recent call last):
  File "C:\build\cpython36\lib\test\test_pathlib.py", line 1547, in test_resolve_common
    self._check_resolve_relative(p, P(d, 'foo'), False)
  File "C:\build\cpython36\lib\test\test_pathlib.py", line 1491, in _check_resolve
    self.assertEqual(q, expected)
AssertionError: WindowsPath('C:/Users/steve.dower/AppData/Local/Temp/2/tmptnm6y2cm-dirD/foo') != WindowsPath('C:/Users/STEVE~1.DOW/AppData/Local/Temp/2/tmptnm6y2cm-dirD/foo')

We should make sure the test is referring to the same file rather than doing a direct path comparison. Maybe write a UUID into a file and read it out?

[barneygale]

This was fixed as part of GH-79158.