Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyObject_New breaks by the commit 7ad6f74fcf9db1ccfeaf0986064870d8d3887300 #94185

Closed
trcrsired opened this issue Jun 23, 2022 · 3 comments
Closed
Labels
type-bug An unexpected behavior, bug, or error

Comments

@trcrsired
Copy link

/usr/local/include/python3.12/objimpl.h:134:46: error: expected ')' before '_PyObject_New'
134 | #define PyObject_New(type, typeobj) ((type *)_PyObject_New(typeobj))
| ~ ^~~~~~~~~~~~~
7ad6f74

This is not working for g++ 13

@trcrsired trcrsired added the type-bug An unexpected behavior, bug, or error label Jun 23, 2022
@vstinner
Copy link
Member

Oh no, writing correct macros is so complicated :-( I wrote PR #94234 to fix this issue.

cc @erlend-aasland

@kumaraditya303
Copy link
Contributor

Fixed by #94234

@vstinner
Copy link
Member

Thanks for reporting the issue! It's great that you catched the issue early, so it could be fixed quickly ;-) I added unit tests to prevent future similar regressions. Sadly, the C API is still not fully tested, as you can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

3 participants