Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning for instantiating abstract class in function #9207

Closed
Holt59 opened this issue Jul 25, 2020 · 1 comment
Closed

No warning for instantiating abstract class in function #9207

Holt59 opened this issue Jul 25, 2020 · 1 comment

Comments

@Holt59
Copy link

Holt59 commented Jul 25, 2020

  • Are you reporting a bug, or opening a feature request?

BUG

  • Please insert below the code you are checking with mypy,
import abc

class A(abc.ABC):
    @abc.abstractmethod
    def f(self): pass

# Cannot instantiate abstract class 'A' with abstract attribute 'f'
a = A()

# Cannot instantiate abstract class 'A' with abstract attribute 'f'
al = lambda: A()

# No warnings
def af():
    return A()

https://mypy-play.net/?mypy=latest&python=3.8&gist=fbc0513ec90bda028634ade70ff698e2

  • What is the actual behavior/output?

See comments above.

  • What is the behavior/output you expect?

I expect the "Cannot instantiate abstract class [...]" warning in all three cases.

@Akuli
Copy link
Contributor

Akuli commented Jul 26, 2020

You need to add type hints to af to make mypy check it:

def af() -> A:
    return A()   # error

This behaviour is documented: https://mypy.readthedocs.io/en/stable/common_issues.html#no-errors-reported-for-obviously-wrong-code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants