Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip typeguard tests #215

Closed
AlexWaygood opened this issue Jun 2, 2023 · 1 comment · Fixed by #235
Closed

Unskip typeguard tests #215

AlexWaygood opened this issue Jun 2, 2023 · 1 comment · Fixed by #235

Comments

@AlexWaygood
Copy link
Member

typeguard's tests are currently skipped in our third_party.yml workflow; we broke some of their tests on 3.7/3.8 with v4.6.0:

typing_extensions/.github/workflows/third_party.yml

Line 143 in aaaa807

if: false # TODO: unskip when typeguard's tests pass on typing_extensions>=4.6.0

We should remember to unskip those tests as soon as they pass with the typing_extensions main branch.
@AlexWaygood
Copy link
Member Author

I've filed this PR to fix the failing tests over at typeguard:

@AlexWaygood AlexWaygood mentioned this issue Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unskip typeguard tests in the third-party workflow AlexWaygood/typing_extensions
1 participant
@AlexWaygood